Skip to content

Remove generics, store hashed paths #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kornelski merged 4 commits into from
Mar 14, 2025
Merged

Remove generics, store hashed paths #80

kornelski merged 4 commits into from
Mar 14, 2025

Conversation

@kornelski
Copy link
Collaborator

@kornelski kornelski commented Mar 14, 2025

  1. Generic args on the server state were noisy, and that isn't perf-sensitive code (we use boxed futures anyway).
  2. Including sha256 in the tarball filename forces it to always match the file expected by the the index, and removes possibility of race conditions overwriting a published tarball with a different content.

@kornelski kornelski requested a review from TheJokr March 14, 2025 14:06
@kornelski kornelski enabled auto-merge (rebase) March 14, 2025 15:34
@kornelski kornelski merged commit f0394ed into main Mar 14, 2025
2 of 11 checks passed
@kornelski kornelski deleted the tarhash branch March 14, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheJokr TheJokr TheJokr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kornelski @TheJokr